]> git.sur5r.net Git - openocd/commit
arm_disassembler: bugfix, MRRC instruction not recognized
authorAlexander Kurz <akurz@blala.de>
Fri, 26 Feb 2016 20:54:22 +0000 (21:54 +0100)
committerAndreas Fritiofson <andreas.fritiofson@gmail.com>
Mon, 29 Feb 2016 19:14:06 +0000 (19:14 +0000)
commit34b32d613af913645bdb0b0e79f10bf0f302ff33
tree75a902f72e2c942e2f23f710aecb5b0b4907a85f
parent6f05ec1e23a764b416fb8b6febcc4e439cd37e76
arm_disassembler: bugfix, MRRC instruction not recognized

A copy-and-paste error in the arm_disassembler opcode evaluation
disabled the recognition of MRRC instructions.
According to the arm architecture ref. manual issue E or later, MRRC and MCRR
instructions are identified by opcode bits 20-27: MCRR = 0xc4, MRRC = 0xc5.
Error found by static code analysis using a semantic pattern to
detect duplicated tests xand.cocci, see coccinellery.org

Change-Id: Ic41426edb51c6816e11dc3d35ef9382ab34af486
Signed-off-by: Alexander Kurz <akurz@blala.de>
Reviewed-on: http://openocd.zylin.com/3363
Reviewed-by: Uwe Bonnes <bon@elektron.ikp.physik.tu-darmstadt.de>
Tested-by: jenkins
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
src/target/arm_disassembler.c