]> git.sur5r.net Git - openocd/commit
Fix underlying problem with xscale icache and dcache commands
authorMike Dunn <mikedunn@newsguy.com>
Fri, 19 Mar 2010 04:34:13 +0000 (21:34 -0700)
committerDavid Brownell <dbrownell@users.sourceforge.net>
Fri, 19 Mar 2010 04:34:13 +0000 (21:34 -0700)
commit8d411d0d249dda7ceb951c4f8c8a509f4fd1dfb0
tree324c00806bb00979d92340a6afd3217582e080f0
parentfc9de56a251a7cfc2610cc1904a69fc7b9fd3011
Fix underlying problem with xscale icache and dcache commands

Fix problem with the xscale icache and dcache commands.  Both commands were
enabling or disabling the mmu, not the caches

I didn't look any further after my earlier patch fixed the trivial problem
with command argument parsing.  Turns out the underlying code was broken.

The resolution is straightforward when you look at the arguments to
xscale_enable_mmu_caches() and xscale_disable_mmu_caches().  I finally
took a deeper look after dumping the cp15 control register (XSCALE_CTRL)
and seeing that the cache bits weren't changing, but the mmu bit was
(which caused all manner of grief, as you can imagine).  This has been
tested and works OK now.

 src/target/xscale.c |   17 +++++++++++------
 1 files changed, 11 insertions(+), 6 deletions(-)

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
src/target/xscale.c