]> git.sur5r.net Git - openocd/commit
command: Fix confusing syntax error message
authorAndreas Fritiofson <andreas.fritiofson@gmail.com>
Tue, 9 Sep 2014 22:13:09 +0000 (00:13 +0200)
committerSpencer Oliver <spen@spen-soft.co.uk>
Mon, 22 Sep 2014 19:40:38 +0000 (19:40 +0000)
commitc0b8e605f7d8cbefcd7a9e47261aa2e06dd2b4e1
tree11d694a4ea70dbd40a28cd0e4ee3fea9e4ee43f4
parent1c021ed0afb5f9f7d9e8cbce53a4fe985a4c2235
command: Fix confusing syntax error message

If the user executes a command with an invalid subcommand, the error
message is extremely unhelpful:

> flash write test.elf
flash write test.elf: command requires more arguments

This is because any command line that starts with a valid command group is
classified as a group, triggering ocd_bouncer to print the confusing
message.

Fix by requiring that to be a command group, the command line must not
contain any unknown tokens after the last valid (sub-)command group. That
is OK because command groups don't have handlers defined and thus can't
take any parameters.

Also fix the error message for "unknown" type to be similar to the error
message that is printed (by Jim) for non-existent primary commands.

Change-Id: I26950349f0909fd3961c4f9ab9b198c221cea9fc
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/2285
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
src/helper/command.c
src/helper/startup.tcl