]> git.sur5r.net Git - openocd/commit
gdb: Potential rounding error in reg_packet_size gdb_get_registers_packet
authorPhilip Nye <philipnye@users.sf.net>
Mon, 14 Nov 2011 20:11:51 +0000 (20:11 +0000)
committerAndreas Fritiofson <andreas.fritiofson@gmail.com>
Thu, 17 Nov 2011 23:10:59 +0000 (23:10 +0000)
commite5e2408680e860cce669b150374188985c442c41
tree913b27e3d91c64a8540931ef64396a47536298bc
parent950f2405197661974225a578630e44667639ccb6
gdb: Potential rounding error in reg_packet_size gdb_get_registers_packet

The calculation for reg_packet_size in gdb_get_registers_packet() could
generate a wrong result in the case of multiple registers whose size is
not a multiple of 8.

The current calculation sums the sizes for all registers then rounds the result
up to the next multiple of 8.

Instead it should round each register size up individually and sum the results for all registers.

Change-Id: Idfb5e5eeee0e69a6889dbe9769c0bf17feacb63b
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/200
Tested-by: jenkins
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
src/server/gdb_server.c