]> git.sur5r.net Git - openocd/commit
ARM: call thumb_pass_branch_condition() only for actual branch opcodes
authorNicolas Pitre <nico@fluxnic.net>
Tue, 27 Oct 2009 05:14:32 +0000 (01:14 -0400)
committerDavid Brownell <dbrownell@users.sourceforge.net>
Tue, 27 Oct 2009 06:53:07 +0000 (23:53 -0700)
commitee8e93cb836bc01581329c5685c888c4d85e6c1b
tree52daa9e552997b645a2f188f44ae94f5462c15ce
parent1020569b9ffa5073df0966b519f05dd492bfa460
ARM: call thumb_pass_branch_condition() only for actual branch opcodes

Calling it first with every opcodes and then testing if the opcode
was indeed a branch instruction is wasteful and rather strange.
If ever thumb_pass_branch_condition() has side effects (say, like
printing a debugging traces) then the result would be garbage for most
Thumb instructions which have no condition code.

While at it, let's make the nearby code more readable by reducing some of
the redundant brace noise and reworking the error handling construct.

Signed-off-by: Nicolas Pitre <nico@marvell.com>
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
src/target/arm_simulator.c