]> git.sur5r.net Git - openldap/commitdiff
add comment about run-time registered extop/control compatibility
authorPierangelo Masarati <ando@openldap.org>
Thu, 12 Jan 2006 08:16:18 +0000 (08:16 +0000)
committerPierangelo Masarati <ando@openldap.org>
Thu, 12 Jan 2006 08:16:18 +0000 (08:16 +0000)
servers/slapd/controls.c

index a8ce25a7ce58c6a6cd7df640ee7014e941a3a9aa..049096c29b58eff30e9251eb792c1b14c46ac2c5 100644 (file)
@@ -286,6 +286,15 @@ register_supported_control2(const char *controloid,
 
        } else {
                if ( sc->sc_extendedopsbv ) {
 
        } else {
                if ( sc->sc_extendedopsbv ) {
+                       /* FIXME: in principle, we should rather merge
+                        * existing extops with those supported by the
+                        * new control handling implementation.
+                        * In fact, whether a control is compatible with
+                        * an extop should not be a matter of implementation.
+                        * We likely also need a means for a newly
+                        * registered extop to declare that it is
+                        * comptible with an already registered control.
+                        */
                        ber_bvarray_free( sc->sc_extendedopsbv );
                        sc->sc_extendedopsbv = NULL;
                        sc->sc_extendedops = NULL;
                        ber_bvarray_free( sc->sc_extendedopsbv );
                        sc->sc_extendedopsbv = NULL;
                        sc->sc_extendedops = NULL;