Properly report errors in 'focus parent' (Thanks eeemsi)

Also, make X11 errors debug log level only. They are harmless usually.

fixes #762

diff --git a/src/commands.c b/src/commands.c
index 964dfe29cd5be6e74f2e604f541564b524d4cd3e..b730bc44ac4ee88f05fcec0609c0f774d5cde67d 100644 (file)
--- a/src/commands.c
+++ b/src/commands.c
@@ -1263,7 +1263,7 @@ void cmd_focus_level(I3_CMD, char *level) {
             if (con_fullscreen_permits_focusing(focused->parent))
                 success = level_up();
             else
-                LOG("Currently in fullscreen, not going up\n");
+                ELOG("'focus parent': Currently in fullscreen, not going up\n");
         }
     }
 

diff --git a/src/main.c b/src/main.c
index aaa5817157f12d8f48f24da9a752ff317ee1ea6c..2c3dc7e9557237034b730025776d530d83013e43 100644 (file)
--- a/src/main.c
+++ b/src/main.c
@@ -121,7 +121,7 @@ static void xcb_check_cb(EV_P_ ev_check *w, int revents) {
                 DLOG("Expected X11 Error received for sequence %x\n", event->sequence);
             else {
                 xcb_generic_error_t *error = (xcb_generic_error_t*)event;
-                ELOG("X11 Error received! sequence 0x%x, error_code = %d\n",
+                DLOG("X11 Error received (probably harmless)! sequence 0x%x, error_code = %d\n",
                      error->sequence, error->error_code);
             }
             free(event);

diff --git a/src/tree.c b/src/tree.c
index 068b05704e8981f6f932e0c1932b244686abae2c..650c9a54877ae9a335f779633f94839ca6265cc3 100644 (file)
--- a/src/tree.c
+++ b/src/tree.c
@@ -389,7 +389,7 @@ bool level_up(void) {
     if ((focused->parent->type != CT_CON &&
         focused->parent->type != CT_WORKSPACE) ||
         focused->type == CT_WORKSPACE) {
-        LOG("Cannot go up any further\n");
+        ELOG("'focus parent': Focus is already on the workspace, cannot go higher than that.\n");
         return false;
     }
     con_focus(focused->parent);