Add comment concerning connections mutex. Need to analysis

locking requires and possibly restructure locking.

diff --git a/servers/slapd/connection.c b/servers/slapd/connection.c
index e06553013719c057a23562820603a25f7741d024..4d8d339e6e1995b3885a373aad8524b880d30fb9 100644 (file)
--- a/servers/slapd/connection.c
+++ b/servers/slapd/connection.c
@@ -318,6 +318,8 @@ long connection_init(
 static void
 connection_destroy( Connection *c )
 {
+       /* note: connections_mutex should be locked by caller */
+
     assert( connections != NULL );
     assert( c != NULL );
     assert( c->c_struct_state != SLAP_C_UNUSED );
@@ -429,6 +431,8 @@ static void connection_close( Connection *c )
        assert( c->c_struct_state == SLAP_C_USED );
        assert( c->c_conn_state == SLAP_C_CLOSING );
 
+       /* note: connections_mutex should be locked by caller */
+
        if( c->c_ops != NULL ) {
                Debug( LDAP_DEBUG_TRACE,
                        "connection_close: deferring conn=%ld sd=%d.\n",