Fix compilation warnings on all Debian architectures. (#3007)

stbuf.st_size is of type off_t, which the standard defines as “extended signed
integral type”¹, and for which there is no correct printf format string. Hence,
we need to cast it into a hopefully-large-enough type (ugh) and use the
corresponding format string. In our case, int64_t should do it, as config files
really shouldn’t be anywhere close to those numbers.

① http://pubs.opengroup.org/onlinepubs/007908799/xsh/systypes.h.html

diff --git a/include/all.h b/include/all.h
index c26835b90ff07e6de3742175fbd9052a7551388e..ecc875d08298f6b33b8b03340b84c8d1e33266a3 100644 (file)
--- a/include/all.h
+++ b/include/all.h
@@ -28,6 +28,7 @@
 #include <errno.h>
 #include <err.h>
 #include <stdint.h>
+#include <inttypes.h>
 #include <math.h>
 #include <limits.h>
 

diff --git a/src/config_parser.c b/src/config_parser.c
index 9d8369c80e46e2b9e1d4503644a717bd0acbaaac..4e66c91109f3f8f37d0dfddbeacc2da6545cb23c 100644 (file)
--- a/src/config_parser.c
+++ b/src/config_parser.c
@@ -902,7 +902,9 @@ bool parse_file(const char *f, bool use_nagbar) {
 
     FREE(current_config);
     current_config = scalloc(stbuf.st_size + 1, 1);
-    fread(current_config, 1, stbuf.st_size, fstr);
+    if ((ssize_t)fread(current_config, 1, stbuf.st_size, fstr) != stbuf.st_size) {
+        die("Could not fread: %s\n", strerror(errno));
+    }
     rewind(fstr);
 
     bool invalid_sets = false;

diff --git a/src/util.c b/src/util.c
index ba0969c729674aabe3dd04a0ce9614803514f4f7..dc3444f7b6aa950be8b4696896ac55b1cc4033fc 100644 (file)
--- a/src/util.c
+++ b/src/util.c
@@ -500,7 +500,7 @@ ssize_t slurp(const char *path, char **buf) {
     size_t n = fread(*buf, 1, stbuf.st_size, f);
     fclose(f);
     if ((ssize_t)n != stbuf.st_size) {
-        ELOG("File \"%s\" could not be read entirely: got %zd, want %zd\n", path, n, stbuf.st_size);
+        ELOG("File \"%s\" could not be read entirely: got %zd, want %" PRIi64 "\n", path, n, (int64_t)stbuf.st_size);
         free(*buf);
         *buf = NULL;
         return -1;