]> git.sur5r.net Git - openocd/commitdiff
target: Fix strange ordering in target_read_u8
authorAndreas Fritiofson <andreas.fritiofson@gmail.com>
Fri, 20 Sep 2013 21:06:24 +0000 (23:06 +0200)
committerSpencer Oliver <spen@spen-soft.co.uk>
Wed, 25 Sep 2013 14:44:34 +0000 (14:44 +0000)
It's been like this since the check was added, in 5aa93a5e.

Change-Id: Iaa0586e0cd1ce57ad92735dcc3e51108a133fe96
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/1640
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
src/target/target.c

index fce1cd42dff740bab04c97e1152b4053350a51ea..4a8d9aaafb91b2c5b183f309d59f003af524845f 100644 (file)
@@ -2031,12 +2031,13 @@ int target_read_u16(struct target *target, uint32_t address, uint16_t *value)
 
 int target_read_u8(struct target *target, uint32_t address, uint8_t *value)
 {
-       int retval = target_read_memory(target, address, 1, 1, value);
        if (!target_was_examined(target)) {
                LOG_ERROR("Target not examined yet");
                return ERROR_FAIL;
        }
 
+       int retval = target_read_memory(target, address, 1, 1, value);
+
        if (retval == ERROR_OK) {
                LOG_DEBUG("address: 0x%8.8" PRIx32 ", value: 0x%2.2x",
                                  address,