]> git.sur5r.net Git - i3/i3/commitdiff
Remove support for resize increment size hints for tiling windows
authorMichael Stapelberg <michael@stapelberg.de>
Tue, 11 Sep 2012 11:11:47 +0000 (13:11 +0200)
committerMichael Stapelberg <michael@stapelberg.de>
Tue, 11 Sep 2012 11:11:47 +0000 (13:11 +0200)
As discussed on the mailing list and the bugtracker.

fixes #540

src/render.c

index 01628c35b6171916a98f0730b8300ad7f48597fa..da993a57206ee13fa130616093dbc1e88fd91f38 100644 (file)
@@ -174,19 +174,11 @@ void render_con(Con *con, bool render_fullscreen) {
             inset->width = new_width;
         }
 
-        if (con->height_increment > 1) {
-            int old_height = inset->height;
-            inset->height -= (inset->height - con->base_height) % con->height_increment;
-            DLOG("Lost %d pixel due to client's height_increment (%d px, base_height = %d)\n",
-                old_height - inset->height, con->height_increment, con->base_height);
-        }
-
-        if (con->width_increment > 1) {
-            int old_width = inset->width;
-            inset->width -= (inset->width - con->base_width) % con->width_increment;
-            DLOG("Lost %d pixel due to client's width_increment (%d px, base_width = %d)\n",
-                old_width - inset->width, con->width_increment, con->base_width);
-        }
+        /* NB: We used to respect resize increment size hints for tiling
+         * windows up until commit 0db93d9 here. However, since all terminal
+         * emulators cope with ignoring the size hints in a better way than we
+         * can (by providing their fake-transparency or background color), this
+         * code was removed. See also http://bugs.i3wm.org/540 */
 
         DLOG("child will be at %dx%d with size %dx%d\n", inset->x, inset->y, inset->width, inset->height);
     }