should we touch timestamps when internally updating?

diff --git a/servers/slapd/back-monitor/conn.c b/servers/slapd/back-monitor/conn.c
index 1cb476a18d22fe4f36dc526d79f9bdc0cbb3e120..40d0a58b91a8121f5901fde17b4f64c9a50093a9 100644 (file)
--- a/servers/slapd/back-monitor/conn.c
+++ b/servers/slapd/back-monitor/conn.c
@@ -217,6 +217,8 @@ monitor_subsys_conn_update(
                }
                a->a_vals[ 0 ].bv_len = len;
                AC_MEMCPY( a->a_vals[ 0 ].bv_val, buf, len + 1 );
+
+               /* FIXME: touch modifyTimestamp? */
        }
 
        return( 0 );

diff --git a/servers/slapd/back-monitor/log.c b/servers/slapd/back-monitor/log.c
index ae1108592a864ee31b7ccd7f1f608704a80e8136..8ab11949e983ede6f3d2c68d8b7fffed83b1d9cc 100644 (file)
--- a/servers/slapd/back-monitor/log.c
+++ b/servers/slapd/back-monitor/log.c
@@ -148,7 +148,9 @@ monitor_subsys_log_modify(
                Modification    *mod = &ml->sml_mod;
 
                /*
-                * accept all operational attributes
+                * accept all operational attributes;
+                * this includes modifersName and modifyTimestamp
+                * if lastmod is "on"
                 */
                if ( is_at_operational( mod->sm_desc->ad_type ) ) {
                        ( void ) attr_delete( &e->e_attrs, mod->sm_desc );

diff --git a/servers/slapd/back-monitor/operation.c b/servers/slapd/back-monitor/operation.c
index 85295e74ddd69ea3a686b44cb17fc633912f0838..8ce09525d3b6a4d18bab52a14c6ad8046e8c2703 100644 (file)
--- a/servers/slapd/back-monitor/operation.c
+++ b/servers/slapd/back-monitor/operation.c
@@ -215,6 +215,8 @@ monitor_subsys_ops_update(
        UI2BV( &a->a_vals[ 0 ], nCompleted );
        ldap_pvt_mp_clear( nCompleted );
 
+       /* FIXME: touch modifyTimestamp? */
+
        return( 0 );
 }
 

diff --git a/servers/slapd/back-monitor/rww.c b/servers/slapd/back-monitor/rww.c
index 52a50436168876a1e51a3a69a8d69eb643b32e7c..150484689779004774a3ea9239b0657ad904eb71 100644 (file)
--- a/servers/slapd/back-monitor/rww.c
+++ b/servers/slapd/back-monitor/rww.c
@@ -217,6 +217,8 @@ monitor_subsys_rww_update(
        AC_MEMCPY( a->a_vals[ 0 ].bv_val, buf, len + 1 );
        a->a_vals[ 0 ].bv_len = len;
 
+       /* FIXME: touch modifyTimestamp? */
+
        return( 0 );
 }
 

diff --git a/servers/slapd/back-monitor/sent.c b/servers/slapd/back-monitor/sent.c
index c5b459432abe4278da425be67b80c353f87bbe22..b7ba178f55a3685d4ab9f979134a5d010f5bfbaa 100644 (file)
--- a/servers/slapd/back-monitor/sent.c
+++ b/servers/slapd/back-monitor/sent.c
@@ -201,6 +201,8 @@ monitor_subsys_sent_update(
        UI2BV( &a->a_vals[ 0 ], n );
        ldap_pvt_mp_clear( n );
 
+       /* FIXME: touch modifyTimestamp? */
+
        return 0;
 }
 

diff --git a/servers/slapd/back-monitor/thread.c b/servers/slapd/back-monitor/thread.c
index f4e8b5878fd938c55d1bb2cc732a40e15ce2a0bf..83ba5ce522c99f8ee54c50ed3c7ebad6f29e6709 100644 (file)
--- a/servers/slapd/back-monitor/thread.c
+++ b/servers/slapd/back-monitor/thread.c
@@ -197,6 +197,8 @@ monitor_subsys_thread_update(
        a->a_vals[ 0 ].bv_len = len;
        AC_MEMCPY( a->a_vals[ 0 ].bv_val, buf, len + 1 );
 
+       /* FIXME: touch modifyTimestamp? */
+
        return( 0 );
 }
 

diff --git a/servers/slapd/back-monitor/time.c b/servers/slapd/back-monitor/time.c
index bc4056b939c1e49436b6e9e698083443092103b3..016b233613861db5dcb254d36bdbe762cc59092d 100644 (file)
--- a/servers/slapd/back-monitor/time.c
+++ b/servers/slapd/back-monitor/time.c
@@ -224,6 +224,8 @@ monitor_subsys_time_update(
 
                assert( len == a->a_vals[ 0 ].bv_len );
                AC_MEMCPY( a->a_vals[ 0 ].bv_val, tmbuf, len );
+
+               /* FIXME: touch modifyTimestamp? */
        }
 
        return( 0 );