]> git.sur5r.net Git - openldap/commitdiff
ITS#7143 add FIXME comment, note that current patch is not ideal
authorHoward Chu <hyc@openldap.org>
Fri, 3 Feb 2012 19:58:00 +0000 (11:58 -0800)
committerHoward Chu <hyc@openldap.org>
Fri, 3 Feb 2012 19:58:00 +0000 (11:58 -0800)
servers/slapd/overlays/rwm.c

index 37e52cb71da9caa49c777d400c5fa5e2510f7cb0..cc6211ed2508d4084d84e088afea42fe18a5471a 100644 (file)
@@ -1277,6 +1277,12 @@ rwm_attrs( Operation *op, SlapReply *rs, Attribute** a_first, int stripEntryDN )
                                                                NULL );
 
                                                        if ( rc != LDAP_SUCCESS ) {
+                                                               /* FIXME: this is wrong, putting a non-normalized value
+                                                                * into nvals. But when a proxy sends us bogus data,
+                                                                * we still need to give it to the client, even if it
+                                                                * violates the syntax. I.e., we don't want to silently
+                                                                * drop things and trigger an apparent data loss.
+                                                                */
                                                                ber_dupbv( &(*ap)->a_nvals[i], &(*ap)->a_vals[i] );
                                                        }
                                                }