]> git.sur5r.net Git - openocd/commitdiff
target/cortex_a: fix compile error for uninitialized variable
authorPaul Bartholomew <oz_paulb@users.sourceforge.net>
Wed, 25 Jul 2018 20:59:01 +0000 (22:59 +0200)
committerMatthias Welwarsky <matthias@welwarsky.de>
Fri, 27 Jul 2018 13:12:08 +0000 (14:12 +0100)
Commit ad6c71e151590f9d07eb07eda978a8d2a845259c introduced the
variable "mmu_enabled" whose pointer is passed to cortex_a_mmu()
that initialises it.
This initialization is not visible to the compiler that issue
a compile error.
The same situation is common across the same file and the usual
workaround is to initialize it to zero; thus the same fix i
applied here.

Ticket: https://sourceforge.net/p/openocd/tickets/197/
Fixes: commit ad6c71e15159 ("cortex_a: fix virt2phys when mmu is disabled")
Change-Id: I77dec41acdf4c715b45ae37b72e36719d96d9283
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/4619
Tested-by: jenkins
Reviewed-by: Matthias Welwarsky <matthias@welwarsky.de>
src/target/cortex_a.c

index b15dcb414f4a6f424dbca7e3fb31ff86eded13a3..e4d8331b291bb721258c77fdbe14229e434fb7ab 100644 (file)
@@ -3229,7 +3229,7 @@ static int cortex_a_virt2phys(struct target *target,
        struct armv7a_common *armv7a = target_to_armv7a(target);
        struct adiv5_dap *swjdp = armv7a->arm.dap;
        uint8_t apsel = swjdp->apsel;
-       int mmu_enabled;
+       int mmu_enabled = 0;
 
        /*
         * If the MMU was not enabled at debug entry, there is no