]> git.sur5r.net Git - openldap/commitdiff
ITS#3950 delete gratuitous yield. (could use pthread_cond_timedwait
authorHoward Chu <hyc@openldap.org>
Sun, 15 Jan 2006 14:21:16 +0000 (14:21 +0000)
committerHoward Chu <hyc@openldap.org>
Sun, 15 Jan 2006 14:21:16 +0000 (14:21 +0000)
if we ever wanted to time out idle threads.)

libraries/libldap_r/tpool.c

index 4e832677941ea605951a5a6720ee68e51dd092b8..e23f9ad09cf8b252c31e89308af11490431b2a41 100644 (file)
@@ -595,6 +595,9 @@ ldap_int_thread_pool_wrapper (
                         * should be like this:
                         *   if (pool->ltp_open_count > 1 && pool->ltp_starting == 0)
                         *       check timer, leave thread (break;)
+                        *
+                        * Just use pthread_cond_timedwait if we want to
+                        * check idle time.
                         */
 
                        if (pool->ltp_state == LDAP_INT_THREAD_POOL_RUNNING
@@ -629,15 +632,6 @@ ldap_int_thread_pool_wrapper (
                        }
                        ldap_pvt_thread_cond_wait(&pool->ltp_cond, &pool->ltp_mutex);
                }
-               ldap_pvt_thread_mutex_unlock(&pool->ltp_mutex);
-
-               ldap_pvt_thread_yield();
-
-               /* if we use an idle timer, here's
-                * a good place to update it
-                */
-
-               ldap_pvt_thread_mutex_lock(&pool->ltp_mutex);
        }
 
        for ( i=0; i<MAXKEYS && ltc_key[i].ltk_key; i++ ) {