Simplify and clean handle_virt2phys_command:

- Add a doxygen block to simplify logic.
- Move declarations to point of first use.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2194 b42882b7-edfa-0310-969c-e2dbd0fdcd60

diff --git a/src/target/target.c b/src/target/target.c
index ea187ea543e9ce8cb4c092b559ad93e69e9793fe..f5d852ab3270ef647e5f25ed70c559ea9a47fc11 100644 (file)
--- a/src/target/target.c
+++ b/src/target/target.c
@@ -2575,30 +2575,27 @@ static int handle_rwp_command(struct command_context_s *cmd_ctx, char *cmd, char
        return ERROR_OK;
 }
 
-static int handle_virt2phys_command(command_context_t *cmd_ctx, char *cmd, char **args, int argc)
-{
-       int retval;
-       target_t *target = get_current_target(cmd_ctx);
-       u32 va;
-       u32 pa;
 
+/**
+ * Translate a virtual address to a physical address.
+ *
+ * The low-level target implementation must have logged a detailed error
+ * which is forwarded to telnet/GDB session.
+ */
+static int handle_virt2phys_command(command_context_t *cmd_ctx,
+               char *cmd, char **args, int argc)
+{
        if (argc != 1)
-       {
                return ERROR_COMMAND_SYNTAX_ERROR;
-       }
-       va = strtoul(args[0], NULL, 0);
 
-       retval = target->type->virt2phys(target, va, &pa);
+       target_t *target = get_current_target(cmd_ctx);
+       u32 va = strtoul(args[0], NULL, 0);
+       u32 pa;
+
+       int retval = target->type->virt2phys(target, va, &pa);
        if (retval == ERROR_OK)
-       {
                command_print(cmd_ctx, "Physical address 0x%08x", pa);
-       }
-       else
-       {
-               /* lower levels will have logged a detailed error which is
-                * forwarded to telnet/GDB session.
-                */
-       }
+
        return retval;
 }