]> git.sur5r.net Git - openldap/commitdiff
Avoid use of uninitialized variable 'e' after failed overlay_entry_get_ov().
authorHallvard Furuseth <hallvard@openldap.org>
Mon, 7 Jan 2008 18:50:54 +0000 (18:50 +0000)
committerHallvard Furuseth <hallvard@openldap.org>
Mon, 7 Jan 2008 18:50:54 +0000 (18:50 +0000)
(It was harmless unless the value was a trap representation.)

servers/slapd/overlays/translucent.c

index 27715316d143b1083fdad2c46062378bf3a66fb2..3fadbbf6b1b935031ef6fa67e5cb2702e7a9d330 100644 (file)
@@ -605,7 +605,7 @@ static int translucent_compare(Operation *op, SlapReply *rs) {
 **
 */
        rc = overlay_entry_get_ov(op, &op->o_req_ndn, NULL, ava->aa_desc, 0, &e, on);
-       if(e && rc == LDAP_SUCCESS) {
+       if(rc == LDAP_SUCCESS && e) {
                overlay_entry_release_ov(op, e, 0, on);
                return(SLAP_CB_CONTINUE);
        }