fix potential leak (detected by Coverity)

diff --git a/servers/slapd/syntax.c b/servers/slapd/syntax.c
index b9fb273fe2176cee579c6dd8ba62b01d2ce7a239..8faffad0413ed7c96b2ff0db2c9563b6d6b0b1de 100644 (file)
--- a/servers/slapd/syntax.c
+++ b/servers/slapd/syntax.c
@@ -164,9 +164,9 @@ syn_add(
        int             code = 0;
 
        ssyn = (Syntax *) SLAP_CALLOC( 1, sizeof(Syntax) );
-       if( ssyn == NULL ) {
+       if ( ssyn == NULL ) {
                Debug( LDAP_DEBUG_ANY, "SLAP_CALLOC Error\n", 0, 0, 0 );
-               return LDAP_OTHER;
+               return SLAP_SCHERR_OUTOFMEM;
        }
 
        AC_MEMCPY( &ssyn->ssyn_syn, syn, sizeof(LDAPSyntax) );
@@ -183,6 +183,8 @@ syn_add(
        ssyn->ssyn_validate = def->sd_validate;
        ssyn->ssyn_pretty = def->sd_pretty;
 
+       ssyn->ssyn_sups = NULL;
+
 #ifdef SLAPD_BINARY_CONVERSION
        ssyn->ssyn_ber2str = def->sd_ber2str;
        ssyn->ssyn_str2ber = def->sd_str2ber;
@@ -208,6 +210,12 @@ syn_add(
 
        if ( code == 0 ) {
                code = syn_insert( ssyn, err );
+
+       } else if ( ssyn != NULL ) {
+               if ( ssyn->ssyn_sups != NULL ) {
+                       ch_free( ssyn->ssyn_sups );
+               }
+               SLAP_FREE( ssyn );
        }
 
        return code;