]> git.sur5r.net Git - i3/i3/commitdiff
tests: add t/215-layout-restore-crash.t for the last couple of commits
authorMichael Stapelberg <michael@stapelberg.de>
Sat, 4 Jan 2014 20:39:33 +0000 (21:39 +0100)
committerMichael Stapelberg <michael@stapelberg.de>
Sat, 4 Jan 2014 20:39:33 +0000 (21:39 +0100)
testcases/t/215-layout-restore-crash.t [new file with mode: 0644]

diff --git a/testcases/t/215-layout-restore-crash.t b/testcases/t/215-layout-restore-crash.t
new file mode 100644 (file)
index 0000000..1d11fec
--- /dev/null
@@ -0,0 +1,191 @@
+#!perl
+# vim:ts=4:sw=4:expandtab
+#
+# Please read the following documents before working on tests:
+# • http://build.i3wm.org/docs/testsuite.html
+#   (or docs/testsuite)
+#
+# • http://build.i3wm.org/docs/lib-i3test.html
+#   (alternatively: perldoc ./testcases/lib/i3test.pm)
+#
+# • http://build.i3wm.org/docs/ipc.html
+#   (or docs/ipc)
+#
+# • http://onyxneon.com/books/modern_perl/modern_perl_a4.pdf
+#   (unless you are already familiar with Perl)
+#
+# Verifies that i3 does not crash when a layout is partially loadable.
+# ticket #1145, bug still present in commit b109b1b20dd51401dc929407453d3acdd8ff5566
+use i3test;
+use File::Temp qw(tempfile);
+use IO::Handle;
+
+################################################################################
+# empty layout file.
+################################################################################
+
+my ($fh, $filename) = tempfile(UNLINK => 1);
+cmd "append_layout $filename";
+
+does_i3_live;
+
+close($fh);
+
+################################################################################
+# file with a superfluous trailing comma
+################################################################################
+
+my $ws = fresh_workspace;
+
+my @content = @{get_ws_content($ws)};
+is(@content, 0, 'no nodes on the new workspace yet');
+
+($fh, $filename) = tempfile(UNLINK => 1);
+print $fh <<'EOT';
+// vim:ts=4:sw=4:et
+{
+    "border": "pixel",
+    "floating": "auto_off",
+    "geometry": {
+       "height": 777,
+       "width": 199,
+       "x": 0,
+       "y": 0
+    },
+    "name": "Buddy List",
+    "percent": 0.116145833333333,
+    "swallows": [
+       {
+       "class": "^Pidgin$",
+       "window_role": "^buddy_list$"
+       }
+    ],
+    "type": "con"
+}
+
+{
+    // splitv split container with 1 children
+    "border": "pixel",
+    "floating": "auto_off",
+    "layout": "splitv",
+    "percent": 0.883854166666667,
+    "swallows": [
+       {}
+    ],
+    "type": "con",
+    "nodes": [
+        {
+            // splitv split container with 2 children
+            "border": "pixel",
+            "floating": "auto_off",
+            "layout": "splitv",
+            "percent": 1,
+            "swallows": [
+               {}
+            ],
+            "type": "con",
+            "nodes": [
+                {
+                    "border": "pixel",
+                    "floating": "auto_off",
+                    "geometry": {
+                       "height": 318,
+                       "width": 566,
+                       "x": 0,
+                       "y": 0
+                    },
+                    "name": "zsh",
+                    "percent": 0.5,
+                    "swallows": [
+                       {
+                         "class": "^URxvt$",
+                         "instance": "^IRC$",
+                       }
+                    ],
+                    "type": "con"
+                },
+                {
+                    "border": "pixel",
+                    "floating": "auto_off",
+                    "geometry": {
+                       "height": 1057,
+                       "width": 636,
+                       "x": 0,
+                       "y": 0
+                    },
+                    "name": "Michael Stapelberg",
+                    "percent": 0.5,
+                    "swallows": [
+                       {
+                         "class": "^Pidgin$",
+                         "window_role": "^conversation$"
+                       }
+                    ],
+                    "type": "con"
+                }
+            ]
+        }
+    ]
+}
+
+EOT
+$fh->flush;
+my $reply = cmd "append_layout $filename";
+diag('reply = ' . Dumper($reply));
+
+does_i3_live;
+
+ok(!$reply->[0]->{success}, 'IPC reply did not indicate success');
+
+close($fh);
+
+################################################################################
+# file with a superfluous trailing comma
+################################################################################
+
+$ws = fresh_workspace;
+
+@content = @{get_ws_content($ws)};
+is(@content, 0, 'no nodes on the new workspace yet');
+
+($fh, $filename) = tempfile(UNLINK => 1);
+print $fh <<'EOT';
+// vim:ts=4:sw=4:et
+{
+    "border": "pixel",
+    "floating": "auto_off",
+    "layout": "splitv",
+    "type": "con",
+    "nodes": [
+        {
+            "border": "pixel",
+            "floating": "auto_off",
+            "geometry": {
+               "height": 318,
+               "width": 566,
+               "x": 0,
+               "y": 0
+            },
+            "name": "zsh",
+            "percent": 0.833333,
+            "swallows": [
+               {
+                 "class": "^URxvt$",
+                 "instance": "^IRC$"
+               }
+            ],
+            "type": "con"
+        }
+    ]
+}
+
+EOT
+$fh->flush;
+cmd "append_layout $filename";
+
+does_i3_live;
+
+close($fh);
+
+
+done_testing;