]> git.sur5r.net Git - openldap/commitdiff
Apply patch to better behave under Solaris threads (thr).
authorKurt Zeilenga <kurt@openldap.org>
Thu, 24 Dec 1998 01:16:22 +0000 (01:16 +0000)
committerKurt Zeilenga <kurt@openldap.org>
Thu, 24 Dec 1998 01:16:22 +0000 (01:16 +0000)
Could still deadlock on the close().  A surrogate parent
should be used to create the children...

servers/slapd/back-shell/fork.c

index 13f099b3316b96abccac2487d7208bb976bf5d65..2c2f9b72f889c1d44fb8628a5b82a4a894c48494 100644 (file)
@@ -32,8 +32,20 @@ forkandexec(
         *      parent *rfp <- c2p[0] | c2p[1] <- stdout child
         */
 
-       switch ( (pid = fork()) ) {
+#ifdef HAVE_THR
+       switch ( (pid = fork1()) )
+#else
+       switch ( (pid = fork()) )
+#endif
+       {
        case 0:         /* child */
+               /*
+                * child could deadlock here due to resources locked
+                * by our parent
+                *
+                * If so, configure --without-threads or implement forking
+                * via a surrogate parent.
+                */
                close( p2c[1] );
                close( c2p[0] );
                if ( dup2( p2c[0], 0 ) == -1 || dup2( c2p[1], 1 ) == -1 ) {