]> git.sur5r.net Git - openldap/commitdiff
Add XXX comment to cache modified from underneath kludge.
authorKurt Zeilenga <kurt@openldap.org>
Tue, 13 Apr 1999 22:41:14 +0000 (22:41 +0000)
committerKurt Zeilenga <kurt@openldap.org>
Tue, 13 Apr 1999 22:41:14 +0000 (22:41 +0000)
servers/slapd/back-ldbm/id2entry.c

index 783fccc8b2acdebe47d6cb8e5c2a28ed894d994b..8c4d8b14095f1bcad2f5ce6989dfa0edc594b56a 100644 (file)
@@ -145,7 +145,7 @@ id2entry_rw( Backend *be, ID id, int rw )
        ldbm_cache_close( be, db );
 
        if ( e == NULL ) {
-               Debug( LDAP_DEBUG_TRACE, "<= id2entry_%s( %ld )  (failed)\n",
+               Debug( LDAP_DEBUG_TRACE, "<= id2entry_%s( %ld ) (failed)\n",
                        rw ? "w" : "r", id, 0 );
                return( NULL );
        }
@@ -160,7 +160,10 @@ id2entry_rw( Backend *be, ID id, int rw )
        if( cache_add_entry_rw( &li->li_cache, e, rw ) != 0 ) {
                entry_free( e );
 
-               /* maybe the entry got added underneath us */
+               /* XXX this is a kludge.
+                * maybe the entry got added underneath us
+                * There are many underlying race condtions in the cache/disk code.
+                */
                if ( (e = cache_find_entry_id( &li->li_cache, id, rw )) != NULL ) {
                        Debug( LDAP_DEBUG_TRACE, "<= id2entry_%s( %ld ) 0x%lx (cache)\n",
                                rw ? "w" : "r", id, (unsigned long) e );