]> git.sur5r.net Git - openldap/commitdiff
Coverity error
authorHoward Chu <hyc@openldap.org>
Tue, 13 Feb 2007 11:03:41 +0000 (11:03 +0000)
committerHoward Chu <hyc@openldap.org>
Tue, 13 Feb 2007 11:03:41 +0000 (11:03 +0000)
servers/slapd/extended.c
servers/slapd/syncrepl.c

index e2420776e7839e582690672bacb51d8da21caf7f..38bb96c14734df866407e4b8faafe8b8fa9a6af4 100644 (file)
@@ -281,7 +281,7 @@ load_extop2(
                LDAP_SUCCESS )
        {
                oidm.bv_val = oidm_find( ext_oid->bv_val );
-               if ( ext_oid == NULL ) {
+               if ( oidm.bv_val == NULL ) {
                        return -1;
                }
                oidm.bv_len = strlen( oidm.bv_val );
index 4d9f28b3b73e750c6b93b98a5c6cadfb4b00e828..ff9debc68574fdf38fbabf0577d801dce39e8ad2 100644 (file)
@@ -1628,13 +1628,11 @@ syncrepl_message_to_entry(
        if ( syncstate == LDAP_SYNC_PRESENT || syncstate == LDAP_SYNC_DELETE ) {
                /* NOTE: this could be done even before decoding the DN,
                 * although encoding errors wouldn't be detected */
-               rc = LDAP_SUCCESS;
-               goto done;
+               return LDAP_SUCCESS;
        }
 
        if ( entry == NULL ) {
-               rc = -1;
-               goto done;
+               return -1;
        }
 
        dnPrettyNormal( NULL, &bdn, &dn, &ndn, op->o_tmpmemctx );