]> git.sur5r.net Git - openocd/commitdiff
Improve handle_profile_command argument parsing:
authorzwelch <zwelch@b42882b7-edfa-0310-969c-e2dbd0fdcd60>
Sat, 13 Jun 2009 00:34:24 +0000 (00:34 +0000)
committerzwelch <zwelch@b42882b7-edfa-0310-969c-e2dbd0fdcd60>
Sat, 13 Jun 2009 00:34:24 +0000 (00:34 +0000)
- Use parse_uint to ensure timeout value parses properly.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2238 b42882b7-edfa-0310-969c-e2dbd0fdcd60

src/target/target.c

index 20e82319fbaa55eea517aeead211884cdf9ed844..e269a5365d3dc707a5d1d496bb7c241c9c442d78 100644 (file)
@@ -2823,12 +2823,12 @@ static int handle_profile_command(struct command_context_s *cmd_ctx, char *cmd,
        {
                return ERROR_COMMAND_SYNTAX_ERROR;
        }
-       char *end;
-       timeval_add_time(&timeout, strtoul(args[0], &end, 0), 0);
-       if (*end)
-       {
-               return ERROR_OK;
-       }
+       unsigned offset;
+       int retval = parse_uint(args[0], &offset);
+       if (ERROR_OK != retval)
+               return retval;
+
+       timeval_add_time(&timeout, offset, 0);
 
        command_print(cmd_ctx, "Starting profiling. Halting and resuming the target as often as we can...");
 
@@ -2838,7 +2838,6 @@ static int handle_profile_command(struct command_context_s *cmd_ctx, char *cmd,
                return ERROR_OK;
 
        int numSamples=0;
-       int retval=ERROR_OK;
        /* hopefully it is safe to cache! We want to stop/restart as quickly as possible. */
        reg_t *reg = register_get_by_name(target->reg_cache, "pc", 1);