slapi/slapi_utils.c rev 1.172 removed the 'dup' parameter to

slapi_int_ldapmods2modifications(), but a 'dup' test remains in the
function body. Should always evaluate to TRUE.

diff --git a/servers/slapd/slapi/slapi_utils.c b/servers/slapd/slapi/slapi_utils.c
index 8d5560109990b337a784c8b054a35e40e9c4bffa..1f4396cd6a793b39d14e943fcb04b16fd794c4d2 100644 (file)
--- a/servers/slapd/slapi/slapi_utils.c
+++ b/servers/slapd/slapi/slapi_utils.c
@@ -2819,8 +2819,7 @@ Modifications *slapi_int_ldapmods2modifications ( LDAPMod **mods, void *memctx )
                                }
                        } else {
                                for ( i = 0; lmod->mod_values[i] != NULL; i++ ) {
-                                       mod->sml_values[i].bv_val = dup ? slapi_ch_strdup( lmod->mod_values[i] ) :
-                                               lmod->mod_values[i];
+                                       mod->sml_values[i].bv_val = slapi_ch_strdup( lmod->mod_values[i] );
                                        mod->sml_values[i].bv_len = strlen( lmod->mod_values[i] );
                                }
                        }