]> git.sur5r.net Git - openldap/commitdiff
add a comment about reworking compare
authorPierangelo Masarati <ando@openldap.org>
Tue, 22 Nov 2005 19:05:43 +0000 (19:05 +0000)
committerPierangelo Masarati <ando@openldap.org>
Tue, 22 Nov 2005 19:05:43 +0000 (19:05 +0000)
servers/slapd/overlays/dynlist.c

index c10bafbcc464a34cde68e7460914f1eb2ed21e5e..93ec9f60e3cc1f38d0d8451a5c1f8d4676f488ef 100644 (file)
@@ -592,6 +592,11 @@ dynlist_response( Operation *op, SlapReply *rs )
                /* NOTE: we waste a few cycles running the dynamic list
                 * also when the result is FALSE, which occurs if the
                 * dynamic entry itself contains the AVA attribute  */
+               /* FIXME: this approach is less than optimal; a dedicated
+                * compare op should be implemented, that fetches the
+                * entry, checks if it has the appropriate objectClass
+                * and, in case, runs a compare thru all the URIs,
+                * stopping at the first positive occurrence; see ITS#3756 */
                case LDAP_COMPARE_FALSE:
                case LDAP_NO_SUCH_ATTRIBUTE:
                        return dynlist_compare( op, rs );