]> git.sur5r.net Git - openocd/commitdiff
target: remove more exit() calls
authorDavid Brownell <dbrownell@users.sourceforge.net>
Tue, 8 Dec 2009 21:09:38 +0000 (13:09 -0800)
committerDavid Brownell <dbrownell@users.sourceforge.net>
Tue, 8 Dec 2009 21:09:38 +0000 (13:09 -0800)
These were all basically "can't happen" cases ... like having
state be corrupted by an alpha particle after the previous check
for whether a value was in-range.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
src/target/arm7_9_common.c
src/target/target.c

index 5563a4e028f7e5c9dcbf37c028cfcc30e443f006..280704ef67059b34e3c3b769c7c1206b4e514587 100644 (file)
@@ -2362,10 +2362,6 @@ int arm7_9_read_memory(struct target *target, uint32_t address, uint32_t size, u
                                }
                        }
                        break;
-               default:
-                       LOG_ERROR("BUG: we shouldn't get here");
-                       exit(-1);
-                       break;
        }
 
        if (!is_arm_mode(armv4_5->core_mode))
@@ -2546,10 +2542,6 @@ int arm7_9_write_memory(struct target *target, uint32_t address, uint32_t size,
                                num_accesses += thisrun_accesses;
                        }
                        break;
-               default:
-                       LOG_ERROR("BUG: we shouldn't get here");
-                       exit(-1);
-                       break;
        }
 
        /* Re-Set DBGACK */
index a9f4dd87462356087bb64047f042af4bccc40111..70130d9127d68fe59c7f3267066d410ea5501a22 100644 (file)
@@ -2154,8 +2154,9 @@ static void handle_md_output(struct command_context *cmd_ctx,
        case 2: value_fmt = "%4.2x "; break;
        case 1: value_fmt = "%2.2x "; break;
        default:
+               /* "can't happen", caller checked */
                LOG_ERROR("invalid memory read size: %u", size);
-               exit(-1);
+               return;
        }
 
        for (unsigned i = 0; i < count; i++)