ITS#8021 env_sync is invalid in RDONLY env

diff --git a/libraries/liblmdb/lmdb.h b/libraries/liblmdb/lmdb.h
index f318ad416dbb9ce779104a3d09b4799862e6e1a7..d22009bbccc68ad874f424a0d9a241f06f731dfe 100644 (file)
--- a/libraries/liblmdb/lmdb.h
+++ b/libraries/liblmdb/lmdb.h
@@ -703,7 +703,8 @@ int  mdb_env_info(MDB_env *env, MDB_envinfo *stat);
         * Data is always written to disk when #mdb_txn_commit() is called,
         * but the operating system may keep it buffered. LMDB always flushes
         * the OS buffers upon commit as well, unless the environment was
-        * opened with #MDB_NOSYNC or in part #MDB_NOMETASYNC.
+        * opened with #MDB_NOSYNC or in part #MDB_NOMETASYNC. This call is
+        * not valid if the environment was opened with #MDB_RDONLY.
         * @param[in] env An environment handle returned by #mdb_env_create()
         * @param[in] force If non-zero, force a synchronous flush.  Otherwise
         *  if the environment has the #MDB_NOSYNC flag set the flushes
@@ -711,6 +712,7 @@ int  mdb_env_info(MDB_env *env, MDB_envinfo *stat);
         * @return A non-zero error value on failure and 0 on success. Some possible
         * errors are:
         * <ul>
+        *      <li>EACCES - the environment is read-only.
         *      <li>EINVAL - an invalid parameter was specified.
         *      <li>EIO - an error occurred during synchronization.
         * </ul>

diff --git a/libraries/liblmdb/mdb.c b/libraries/liblmdb/mdb.c
index b6703d6857890a9de4776255d4e14a0489b9cc3a..121c53c3d9bf443a85dbf2129f86700bfe2c3a1a 100644 (file)
--- a/libraries/liblmdb/mdb.c
+++ b/libraries/liblmdb/mdb.c
@@ -2348,6 +2348,8 @@ int
 mdb_env_sync(MDB_env *env, int force)
 {
        int rc = 0;
+       if (env->me_flags & MDB_RDONLY)
+               return EACCES;
        if (force || !F_ISSET(env->me_flags, MDB_NOSYNC)) {
                if (env->me_flags & MDB_WRITEMAP) {
                        int flags = ((env->me_flags & MDB_MAPASYNC) && !force)