Return "no battery" instead of dying if a battery wasn’t found (Thanks Mirko)

diff --git a/i3status.h b/i3status.h
index 241307a2b73d3cf242b45cc2bfcfc2915839ed02..0eb9ce1293d5646cb60fcfe1b4f903039b5a28bf 100644 (file)
--- a/i3status.h
+++ b/i3status.h
@@ -50,7 +50,7 @@ void create_file(const char *name);
 char *order_to_str(int number, char *name);
 void setup(void);
 void write_to_statusbar(const char *name, const char *message, bool final_entry);
-void slurp(char *filename, char *destination, int size);
+bool slurp(char *filename, char *destination, int size);
 
 /* src/output.c */
 void write_error_to_statusbar(const char *message);

diff --git a/src/general.c b/src/general.c
index 62d242db6fa387c5bb7f9feb81a61298a865065d..8d48f749ddbb9f6232dca6f9e4d7436a7be65b70 100644 (file)
--- a/src/general.c
+++ b/src/general.c
@@ -13,14 +13,16 @@
  * Reads size bytes into the destination buffer from filename.
  *
  */
-void slurp(char *filename, char *destination, int size) {
+bool slurp(char *filename, char *destination, int size) {
         int fd;
 
         if ((fd = open(filename, O_RDONLY)) == -1)
-                die("Could not open \"%s\"\n", filename);
+                return false;
 
         (void)read(fd, destination, size);
         (void)close(fd);
+
+        return true;
 }
 
 /*

diff --git a/src/get_battery_info.c b/src/get_battery_info.c
index 8ac7743eef09d1682643be9477568cc14542cd45..41f2ff36d89731088bf0605068856a6684576eaa 100644 (file)
--- a/src/get_battery_info.c
+++ b/src/get_battery_info.c
@@ -26,7 +26,8 @@ const char *get_battery_info(struct battery *bat) {
         charging_status_t status = CS_DISCHARGING;
 
 #if defined(LINUX)
-        slurp(bat->path, buf, sizeof(buf));
+        if (!slurp(bat->path, buf, sizeof(buf)))
+                return "No battery";
 
         for (walk = buf, last = buf; (walk-buf) < 1024; walk++) {
                 if (*walk == '\n') {

diff --git a/src/get_cpu_temperature.c b/src/get_cpu_temperature.c
index 09fbd25f7eff3f3b0af9274a7cfacd129431f373..ca6b9df800d6e1f11e743e6e77ef9c05b51fe07d 100644 (file)
--- a/src/get_cpu_temperature.c
+++ b/src/get_cpu_temperature.c
@@ -24,7 +24,8 @@ const char *get_cpu_temperature_info() {
 
 #if defined(LINUX)
         long int temp;
-        slurp(thermal_zone, buf, sizeof(buf));
+        if (!slurp(thermal_zone, buf, sizeof(buf)))
+                die("Could not open \"%s\"\n", thermal_zone);
         temp = strtol(buf, NULL, 10);
         if (temp == LONG_MIN || temp == LONG_MAX || temp <= 0)
                 (void)snprintf(buf, sizeof(buf), "T: ? C");

diff --git a/src/get_wireless_info.c b/src/get_wireless_info.c
index 4d8d0b25a7c38f62a5f32ec4c2b22d8ae5172a84..c257f5634e17f47e88c170db8dcd7df99437bf58 100644 (file)
--- a/src/get_wireless_info.c
+++ b/src/get_wireless_info.c
@@ -20,7 +20,8 @@ const char *get_wireless_info() {
         memset(buf, 0, sizeof(buf));
         memset(part, 0, sizeof(part));
 
-        slurp("/proc/net/wireless", buf, sizeof(buf));
+        if (!slurp("/proc/net/wireless", buf, sizeof(buf)))
+                die("Could not open \"/proc/net/wireless\"\n");
 
         interfaces = skip_character(buf, '\n', 1) + 1;
         while ((interfaces = skip_character(interfaces, '\n', 1)+1) < buf+strlen(buf)) {