From: Spencer Oliver Date: Mon, 30 Jan 2012 13:15:08 +0000 (+0000) Subject: checkpatch: remove typedef check X-Git-Tag: v0.6.0-rc1~266 X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;ds=sidebyside;h=2f6f7c442d24ba296dd9447e254e34b817fd02b4;p=openocd checkpatch: remove typedef check We may enable this again - but at the moment is causing extra issues with reformatting the codebase. Change-Id: Ic64310a20605a0ef3206caa15c8e6c8ee655bfda Signed-off-by: Spencer Oliver Reviewed-on: http://openocd.zylin.com/413 Tested-by: jenkins --- diff --git a/tools/scripts/checkpatch.pl b/tools/scripts/checkpatch.pl index 50fffc17..cabfa679 100755 --- a/tools/scripts/checkpatch.pl +++ b/tools/scripts/checkpatch.pl @@ -2121,14 +2121,14 @@ sub process { # check for new typedefs, only function parameters and sparse annotations # make sense. - if ($line =~ /\btypedef\s/ && - $line !~ /\btypedef\s+$Type\s*\(\s*\*?$Ident\s*\)\s*\(/ && - $line !~ /\btypedef\s+$Type\s+$Ident\s*\(/ && - $line !~ /\b$typeTypedefs\b/ && - $line !~ /\b__bitwise(?:__|)\b/) { - WARN("NEW_TYPEDEFS", - "do not add new typedefs\n" . $herecurr); - } +# if ($line =~ /\btypedef\s/ && +# $line !~ /\btypedef\s+$Type\s*\(\s*\*?$Ident\s*\)\s*\(/ && +# $line !~ /\btypedef\s+$Type\s+$Ident\s*\(/ && +# $line !~ /\b$typeTypedefs\b/ && +# $line !~ /\b__bitwise(?:__|)\b/) { +# WARN("NEW_TYPEDEFS", +# "do not add new typedefs\n" . $herecurr); +# } # * goes on variable not on type # (char*[ const])