From: Howard Chu <hyc@symas.com>
Date: Tue, 16 Sep 2014 20:54:07 +0000 (+0100)
Subject: Silence some clang warnings
X-Git-Tag: OPENLDAP_REL_ENG_2_4_40~3^2~1
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;ds=sidebyside;h=674f52fdb4ee29df88c8b4e20e0edfb5d5ba3138;p=openldap

Silence some clang warnings
---

diff --git a/libraries/liblmdb/mdb_dump.c b/libraries/liblmdb/mdb_dump.c
index 3b01f9643d..0eb85fd20e 100644
--- a/libraries/liblmdb/mdb_dump.c
+++ b/libraries/liblmdb/mdb_dump.c
@@ -233,6 +233,10 @@ int main(int argc, char *argv[])
 
 	envname = argv[optind];
 	rc = mdb_env_create(&env);
+	if (rc) {
+		fprintf(stderr, "mdb_env_create failed, error %d %s\n", rc, mdb_strerror(rc));
+		return EXIT_FAILURE;
+	}
 
 	if (alldbs || subname) {
 		mdb_env_set_maxdbs(env, 2);
diff --git a/libraries/liblmdb/mdb_load.c b/libraries/liblmdb/mdb_load.c
index 268fe0db54..e0d95e13c3 100644
--- a/libraries/liblmdb/mdb_load.c
+++ b/libraries/liblmdb/mdb_load.c
@@ -64,8 +64,6 @@ flagbit dbflags[] = {
 	{ 0, NULL, 0 }
 };
 
-static const char hexc[] = "0123456789abcdef";
-
 static void readhdr(void)
 {
 	char *ptr;
@@ -345,6 +343,10 @@ int main(int argc, char *argv[])
 
 	envname = argv[optind];
 	rc = mdb_env_create(&env);
+	if (rc) {
+		fprintf(stderr, "mdb_env_create failed, error %d %s\n", rc, mdb_strerror(rc));
+		return EXIT_FAILURE;
+	}
 
 	mdb_env_set_maxdbs(env, 2);
 
diff --git a/libraries/liblmdb/mdb_stat.c b/libraries/liblmdb/mdb_stat.c
index 25c092c04f..1e9229296f 100644
--- a/libraries/liblmdb/mdb_stat.c
+++ b/libraries/liblmdb/mdb_stat.c
@@ -105,6 +105,10 @@ int main(int argc, char *argv[])
 
 	envname = argv[optind];
 	rc = mdb_env_create(&env);
+	if (rc) {
+		fprintf(stderr, "mdb_env_create failed, error %d %s\n", rc, mdb_strerror(rc));
+		return EXIT_FAILURE;
+	}
 
 	if (alldbs || subname) {
 		mdb_env_set_maxdbs(env, 4);
@@ -117,8 +121,8 @@ int main(int argc, char *argv[])
 	}
 
 	if (envinfo) {
-		rc = mdb_env_stat(env, &mst);
-		rc = mdb_env_info(env, &mei);
+		(void)mdb_env_stat(env, &mst);
+		(void)mdb_env_info(env, &mei);
 		printf("Environment Info\n");
 		printf("  Map address: %p\n", mei.me_mapaddr);
 		printf("  Map size: %"Z"u\n", mei.me_mapsize);