From: Jan Vcelak Date: Wed, 6 Jun 2012 12:44:53 +0000 (+0200) Subject: ITS#7291 MozNSS: read pin from file file can cause infinite loop X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=00d0e162720b8cf03b9e5428892158f0768db9a6;p=openldap ITS#7291 MozNSS: read pin from file file can cause infinite loop The buffer allocated for reading password file has to be initialized with zeros, or we need to append zero at the end of the file. Otherwise we might read unitialized memory and consider it to be a password. --- diff --git a/libraries/libldap/tls_m.c b/libraries/libldap/tls_m.c index d71fec74ad..2e755ebd18 100644 --- a/libraries/libldap/tls_m.c +++ b/libraries/libldap/tls_m.c @@ -786,7 +786,7 @@ tlsm_get_pin_from_file(const char *token_name, tlsm_ctx *ctx) } /* create a buffer to hold the file contents */ - if ( !( contents = PR_MALLOC( file_info.size + 1 ) ) ) { + if ( !( contents = PR_CALLOC( file_info.size + 1 ) ) ) { PRErrorCode errcode = PR_GetError(); Debug( LDAP_DEBUG_ANY, "TLS: could not alloc a buffer for contents of pin file %s - error %d:%s.\n",