From: Pierangelo Masarati <ando@openldap.org>
Date: Fri, 28 Dec 2001 18:18:16 +0000 (+0000)
Subject: a couple of comments; will require special DN handling ...
X-Git-Tag: LDBM_PRE_GIANT_RWLOCK~425
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=04ce28cf4873596fa140cec3e589d94273900bb0;p=openldap

a couple of comments; will require special DN handling ...
---

diff --git a/servers/slapd/aclparse.c b/servers/slapd/aclparse.c
index 7c5d27f4c8..53f1daf418 100644
--- a/servers/slapd/aclparse.c
+++ b/servers/slapd/aclparse.c
@@ -1189,6 +1189,12 @@ acl_regex_normalized_dn(
 	for ( p = str; p && p[ 0 ]; p++ ) {
 		/* escape */
 		if ( p[ 0 ] == '\\' ) {
+			/* 
+			 * if escaping a hex pair we should
+			 * increment p twice; however, in that 
+			 * case the second hex number does 
+			 * no harm
+			 */
 			p++;
 		}
 
@@ -1196,6 +1202,10 @@ acl_regex_normalized_dn(
 			if ( p[ 1 ] == ' ' ) {
 				char *q;
 			
+				/*
+				 * too much space should be 
+				 * an error if we are pedantic
+				 */
 				for ( q = &p[ 2 ]; q[ 0 ] == ' '; q++ ) {
 					/* DO NOTHING */ ;
 				}