From: Alexander Monakov <amonakov@ispras.ru>
Date: Thu, 18 Dec 2014 15:23:25 +0000 (+0300)
Subject: Avoid use of uninitialized variable in print_battery_info
X-Git-Tag: 2.9~8
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=05273b03fda3824bc640319999343040fca81635;p=i3%2Fi3status

Avoid use of uninitialized variable in print_battery_info

The boolean flag 'watt_as_unit' may be used without being initialized if the
configured battery path does not contain expected statistics (for example if
it is misconfigured and points to AC adapter info or simply an unrelated file).

Even though it does not cause ill effects, it causes a warning (true positive)
when running i3status under Valgrind.  Initialize the variable to make code
well-defined.
---

diff --git a/src/print_battery_info.c b/src/print_battery_info.c
index 28b94ec..0df9b72 100644
--- a/src/print_battery_info.c
+++ b/src/print_battery_info.c
@@ -44,7 +44,7 @@ void print_battery_info(yajl_gen json_gen, char *buffer, int number, const char
         char consumptionbuf[256];
         const char *walk, *last;
         char *outwalk = buffer;
-        bool watt_as_unit;
+        bool watt_as_unit = false;
         bool colorful_output = false;
         int full_design = -1,
             remaining = -1,