From: Alexander Graf Date: Fri, 5 Aug 2016 12:51:47 +0000 (+0200) Subject: efi_loader: disk: Sanitize exposed devices X-Git-Tag: v2016.09-rc2~79 X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=0812d1a094c402db4fc25ca988113a6d6663c70f;p=u-boot efi_loader: disk: Sanitize exposed devices When a target device is 0 bytes long, there's no point in exposing it to the user. Let's just skip them. Also, when an offset is passed into the efi disk creation, we should remove this offset from the total number of sectors we can handle. This patch fixes both things. Signed-off-by: Alexander Graf --- diff --git a/lib/efi_loader/efi_disk.c b/lib/efi_loader/efi_disk.c index e00a747980..d8ddcc9b42 100644 --- a/lib/efi_loader/efi_disk.c +++ b/lib/efi_loader/efi_disk.c @@ -202,6 +202,10 @@ static void efi_disk_add_dev(const char *name, struct efi_device_path_file_path *dp; int objlen = sizeof(*diskobj) + (sizeof(*dp) * 2); + /* Don't add empty devices */ + if (!desc->lba) + return; + diskobj = calloc(1, objlen); /* Fill in object data */ @@ -221,7 +225,7 @@ static void efi_disk_add_dev(const char *name, diskobj->media.media_present = 1; diskobj->media.block_size = desc->blksz; diskobj->media.io_align = desc->blksz; - diskobj->media.last_block = desc->lba; + diskobj->media.last_block = desc->lba - offset; diskobj->ops.media = &diskobj->media; /* Fill in device path */