From: Michael Stapelberg <michael@stapelberg.de>
Date: Wed, 24 May 2017 18:41:17 +0000 (+0200)
Subject: no-op change: move bind->release check into loop
X-Git-Tag: 4.14~27^2~2
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=0acd11a8d71a120edf3d2cfe327ec678bb1b63af;p=i3%2Fi3

no-op change: move bind->release check into loop

We don’t have to negate the check anymore, making it more readable.
---

diff --git a/src/bindings.c b/src/bindings.c
index 0a994f55..e9aec2c6 100644
--- a/src/bindings.c
+++ b/src/bindings.c
@@ -268,14 +268,12 @@ static Binding *get_binding(i3_event_state_mask_t state_filtered, bool is_releas
                 const bool mods_match = modifiers_match(modifiers_mask, modifiers_state);
                 DLOG("binding_keycode->modifiers = %d, modifiers_mask = %d, modifiers_state = %d, mods_match = %s\n",
                      binding_keycode->modifiers, modifiers_mask, modifiers_state, (mods_match ? "yes" : "no"));
-                if (mods_match) {
+                if (mods_match || (bind->release == B_UPON_KEYRELEASE_IGNORE_MODS && is_release)) {
                     found_keycode = true;
                     break;
                 }
             }
-            if (!found_keycode &&
-                (bind->release != B_UPON_KEYRELEASE_IGNORE_MODS ||
-                 !is_release)) {
+            if (!found_keycode) {
                 continue;
             }
         }