From: Aaron Durbin Date: Tue, 20 May 2014 12:01:38 +0000 (-0600) Subject: power: Explicitly select pmic device's bus X-Git-Tag: v2014.07-rc3~4^2~2^2~7 X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=0b259dc2e849183dfea604fa137bb616e09b319a;p=u-boot power: Explicitly select pmic device's bus The current pmic i2c code assumes the current i2c bus is the same as the pmic device's bus. There is nothing ensuring that to be true. Therefore, select the proper bus before performing a transaction. Signed-off-by: Aaron Durbin Signed-off-by: Simon Glass Acked-by: Heiko Schocher Reviewed-by: Simon Glass Signed-off-by: Minkyu Kang --- diff --git a/drivers/power/power_i2c.c b/drivers/power/power_i2c.c index ac768708ea..594cd11725 100644 --- a/drivers/power/power_i2c.c +++ b/drivers/power/power_i2c.c @@ -23,6 +23,8 @@ int pmic_reg_write(struct pmic *p, u32 reg, u32 val) if (check_reg(p, reg)) return -1; + I2C_SET_BUS(p->bus); + switch (pmic_i2c_tx_num) { case 3: if (p->sensor_byte_order == PMIC_SENSOR_BYTE_ORDER_BIG) { @@ -66,6 +68,8 @@ int pmic_reg_read(struct pmic *p, u32 reg, u32 *val) if (check_reg(p, reg)) return -1; + I2C_SET_BUS(p->bus); + if (i2c_read(pmic_i2c_addr, reg, 1, buf, pmic_i2c_tx_num)) return -1;