From: Orestis Floros <orestisf1993@gmail.com>
Date: Thu, 26 Apr 2018 21:08:58 +0000 (+0300)
Subject: Fix redundant casts to the same type
X-Git-Tag: 4.16~88^2~1
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=0b5a2092a08f7e4463b5d52e11d84750af84e73c;p=i3%2Fi3

Fix redundant casts to the same type

Found using clang-tidy's google-readability-casting.
---

diff --git a/i3-nagbar/main.c b/i3-nagbar/main.c
index e4628e30..3e5f43e3 100644
--- a/i3-nagbar/main.c
+++ b/i3-nagbar/main.c
@@ -115,7 +115,7 @@ static void start_application(const char *command) {
         setsid();
         if (fork() == 0) {
             /* This is the child */
-            execl(_PATH_BSHELL, _PATH_BSHELL, "-c", command, (void *)NULL);
+            execl(_PATH_BSHELL, _PATH_BSHELL, "-c", command, NULL);
             /* not reached */
         }
         exit(0);
diff --git a/libi3/ucs2_conversion.c b/libi3/ucs2_conversion.c
index 75cff78a..398c1ae5 100644
--- a/libi3/ucs2_conversion.c
+++ b/libi3/ucs2_conversion.c
@@ -83,8 +83,7 @@ xcb_char2b_t *convert_utf8_to_ucs2(char *input, size_t *real_strlen) {
     }
 
     /* Do the conversion */
-    size_t rc = iconv(ucs2_conversion_descriptor, (char **)&input,
-                      &input_size, (char **)&output, &output_size);
+    size_t rc = iconv(ucs2_conversion_descriptor, &input, &input_size, (char **)&output, &output_size);
     if (rc == (size_t)-1) {
         perror("Converting to UCS-2 failed");
         free(buffer);
diff --git a/src/startup.c b/src/startup.c
index 1e733fcb..b1a2f602 100644
--- a/src/startup.c
+++ b/src/startup.c
@@ -191,7 +191,7 @@ void start_application(const char *command, bool no_startup_id) {
             if (!no_startup_id)
                 sn_launcher_context_setup_child_process(context);
 
-            execl(_PATH_BSHELL, _PATH_BSHELL, "-c", command, (void *)NULL);
+            execl(_PATH_BSHELL, _PATH_BSHELL, "-c", command, NULL);
             /* not reached */
         }
         _exit(0);