From: xypron.glpk@gmx.de <xypron.glpk@gmx.de>
Date: Wed, 3 May 2017 21:31:58 +0000 (+0200)
Subject: arm64: mvebu: incorrect check of fdt address cells
X-Git-Tag: v2017.05~5
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=1275a44e2f0579aba11d59c92c1717d5f9abc5e9;p=u-boot

arm64: mvebu: incorrect check of fdt address cells

In dram_init_banksize there seems to be a typo concerning
a plausibility check of the fdt.
Testing sc > 2 twice does not make any sense.

The problem was indicated by cppcheck.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---

diff --git a/arch/arm/mach-mvebu/arm64-common.c b/arch/arm/mach-mvebu/arm64-common.c
index 1c0477a3ca..2ef5726905 100644
--- a/arch/arm/mach-mvebu/arm64-common.c
+++ b/arch/arm/mach-mvebu/arm64-common.c
@@ -94,7 +94,7 @@ int dram_init_banksize(void)
 
 	ac = fdt_address_cells(fdt, 0);
 	sc = fdt_size_cells(fdt, 0);
-	if (ac < 1 || sc > 2 || sc < 1 || sc > 2) {
+	if (ac < 1 || ac > 2 || sc < 1 || sc > 2) {
 		printf("invalid address/size cells\n");
 		return -ENXIO;
 	}