From: Łukasz Majewski Date: Wed, 5 Dec 2012 08:06:40 +0000 (+0000) Subject: fs:ext4:write: Initialize cache aligned filename buffer X-Git-Tag: v2013.01-rc2~74 X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=13d43555a9154cf12255023c47e80d947d7d0604;p=u-boot fs:ext4:write: Initialize cache aligned filename buffer The filename buffer is allocated dynamically. It must be cache aligned. Moreover, it is necessary to erase its content before we use it for file name operations. This prevents from corruption of written file names. Signed-off-by: Lukasz Majewski Signed-off-by: Kyungmin Park --- diff --git a/fs/ext4/ext4fs.c b/fs/ext4/ext4fs.c index 64d8a6d972..f02c215ccc 100644 --- a/fs/ext4/ext4fs.c +++ b/fs/ext4/ext4fs.c @@ -1011,8 +1011,6 @@ int ext4fs_write(const char *fname, unsigned char *buffer, unsigned int blks_reqd_for_file; unsigned int blocks_remaining; int existing_file_inodeno; - char filename[256]; - char *temp_ptr = NULL; long int itable_blkno; long int parent_itable_blkno; @@ -1021,6 +1019,9 @@ int ext4fs_write(const char *fname, unsigned char *buffer, unsigned int inodes_per_block; unsigned int ibmap_idx; struct ext_filesystem *fs = get_fs(); + ALLOC_CACHE_ALIGN_BUFFER(char, filename, 256); + memset(filename, 0x00, sizeof(filename)); + g_parent_inode = zalloc(sizeof(struct ext2_inode)); if (!g_parent_inode) goto fail;