From: Michael Stapelberg <michael@stapelberg.de>
Date: Wed, 2 Jun 2010 15:03:26 +0000 (+0200)
Subject: Don’t ignore sequence in UnmapNotify, there might be multiple windows in one sequence
X-Git-Tag: tree-pr1~192
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=1c5adc6c35cffaedc08c7d1dd1b03a3269d1367c;p=i3%2Fi3

Don’t ignore sequence in UnmapNotify, there might be multiple windows in one sequence

This would lead to i3 thinking that a new window was already managed if it
has the same X-ID as the old window. Instead, we need to fix the EnterNotify
problem in a different way.
---

diff --git a/src/handlers.c b/src/handlers.c
index e351aea0..91872e4b 100644
--- a/src/handlers.c
+++ b/src/handlers.c
@@ -454,9 +454,11 @@ int handle_unmap_notify_event(void *data, xcb_connection_t *conn, xcb_unmap_noti
 
     bool ignored = event_is_ignored(event->sequence);
 
+    /* FIXME: we cannot ignore this sequence because more UnmapNotifys with the same sequence
+     * numbers but different window IDs may follow */
     /* we need to ignore EnterNotify events which will be generated because a
      * different window is visible now */
-    add_ignore_event(event->sequence);
+    //add_ignore_event(event->sequence);
 
     DLOG("UnmapNotify for 0x%08x (received from 0x%08x), serial %d\n", event->window, event->event, event->sequence);
     if (ignored) {