From: ntfreak Date: Wed, 23 Jul 2008 22:24:02 +0000 (+0000) Subject: - comment about dummy ack '+' char from gdb X-Git-Tag: v0.1.0~435 X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=1c92ff6a04b27b0aee1058db0b605b73c0dc296c;p=openocd - comment about dummy ack '+' char from gdb git-svn-id: svn://svn.berlios.de/openocd/trunk@864 b42882b7-edfa-0310-969c-e2dbd0fdcd60 --- diff --git a/src/server/gdb_server.c b/src/server/gdb_server.c index 8db55df0..cea5ad0d 100644 --- a/src/server/gdb_server.c +++ b/src/server/gdb_server.c @@ -287,7 +287,6 @@ int gdb_put_packet_inner(connection_t *connection, char *buffer, int len) * however sometimes '-' is sent even though we've already received * an ACK (+) for everything we've sent off. */ -#ifndef _WIN32 int gotdata; for (;;) { @@ -299,7 +298,6 @@ int gdb_put_packet_inner(connection_t *connection, char *buffer, int len) return retval; LOG_WARNING("Discard unexpected char %c", reply); } -#endif #endif while (1) @@ -413,6 +411,8 @@ int gdb_get_packet_inner(connection_t *connection, char *buffer, int *len) case '$': break; case '+': + /* gdb sends a dummy ack '+' at every remote connect - see remote_start_remote (remote.c) + * incase anyone tries to debug why they receive this warning every time */ LOG_WARNING("acknowledgment received, but no packet pending"); break; case '-': @@ -509,7 +509,6 @@ int gdb_get_packet_inner(connection_t *connection, char *buffer, int *len) my_checksum += character & 0xff; buffer[count++] = character & 0xff; } - } *len = count;