From: leo@yuriev.ru Date: Fri, 17 Oct 2014 22:22:39 +0000 (+0000) Subject: ITS#7969 LMDB: volatile. X-Git-Tag: LMDB_0.9.15~33 X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=1e5d79831c8a7cb56115f76c492d1e18622f16b0;p=openldap ITS#7969 LMDB: volatile. Globally shared fields of meta-data were not 'volatile'. Code from 9a80a8a8e8feed56fbccd8851b8a789f7fff9c11, except the unportable __synchronize(). --- diff --git a/libraries/liblmdb/mdb.c b/libraries/liblmdb/mdb.c index ab3b3a0d5e..89d4a2a257 100644 --- a/libraries/liblmdb/mdb.c +++ b/libraries/liblmdb/mdb.c @@ -588,11 +588,11 @@ typedef struct MDB_rxbody { * started from so we can avoid overwriting any data used in that * particular version. */ - txnid_t mrb_txnid; + volatile txnid_t mrb_txnid; /** The process ID of the process owning this reader txn. */ - MDB_PID_T mrb_pid; + volatile MDB_PID_T mrb_pid; /** The thread ID of the thread owning this txn. */ - MDB_THR_T mrb_tid; + volatile MDB_THR_T mrb_tid; } MDB_rxbody; /** The actual reader record, with cacheline padding. */ @@ -640,12 +640,12 @@ typedef struct MDB_txbody { * This is recorded here only for convenience; the value can always * be determined by reading the main database meta pages. */ - txnid_t mtb_txnid; + volatile txnid_t mtb_txnid; /** The number of slots that have been used in the reader table. * This always records the maximum count, it is not decremented * when readers release their slots. */ - unsigned mtb_numreaders; + volatile unsigned mtb_numreaders; } MDB_txbody; /** The actual reader table definition. */ @@ -916,7 +916,7 @@ typedef struct MDB_meta { /** Any persistent environment flags. @ref mdb_env */ #define mm_flags mm_dbs[0].md_flags pgno_t mm_last_pg; /**< last used page in file */ - txnid_t mm_txnid; /**< txnid that committed this page */ + volatile txnid_t mm_txnid; /**< txnid that committed this page */ } MDB_meta; /** Buffer for a stack-allocated meta page.