From: Uwe Bonnes Date: Fri, 7 Nov 2014 13:28:43 +0000 (+0100) Subject: Hacking: Some note how to review. X-Git-Tag: v0.9.0-rc1~233 X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=2162ca72ef74a8bc74e7db7f1c05c8a3610b3482;p=openocd Hacking: Some note how to review. Change-Id: Ied682884abdba27da265f1ce3632417f54a80fe2 Signed-off-by: Uwe Bonnes Reviewed-on: http://openocd.zylin.com/2380 Tested-by: jenkins Reviewed-by: Spencer Oliver --- diff --git a/HACKING b/HACKING index c2e841ab..162da869 100644 --- a/HACKING +++ b/HACKING @@ -172,6 +172,13 @@ not have to) be disregarded if all conditions listed below are met: @section browsing Browsing Patches All OpenOCD patches can be reviewed here. + +@section reviewing Reviewing Patches +From the main Review +page select the patch you want to review and click on that patch. On the +appearing page select the download method (top right). Apply the +patch. After building and testing you can leave a note with the "Reply" +button and mark the patch with -1, 0 and +1. */ /** @file This file contains the @ref patchguide page.