From: Guenter Roeck <linux@roeck-us.net>
Date: Sun, 3 Sep 2017 20:58:47 +0000 (-0700)
Subject: Update pwm cached control registers before writing pwm enable
X-Git-Tag: v1.0~10
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=21b0f8cf1ec7aef9a6ee8afaf97cadd15ecb8f2e;p=groeck-it87

Update pwm cached control registers before writing pwm enable

If pwmX_enable is written prior to displaying any attributes,
t87_update_pwm_ctrl() is never called, and the cached pwm registers
are never read before written. This results in bad values written
into various registers, and can result in operational failures.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---

diff --git a/it87.c b/it87.c
index 9bb5d5b..8404802 100644
--- a/it87.c
+++ b/it87.c
@@ -1623,6 +1623,7 @@ static ssize_t set_pwm_enable(struct device *dev, struct device_attribute *attr,
 	}
 
 	mutex_lock(&data->update_lock);
+	it87_update_pwm_ctrl(data, nr);
 
 	if (val == 0) {
 		if (nr < 3 && has_fanctl_onoff(data)) {