From: Pierangelo Masarati <ando@openldap.org>
Date: Sun, 2 Nov 2008 21:06:50 +0000 (+0000)
Subject: controls can always have criticality set to FALSE (ITS#5785)
X-Git-Tag: ACLCHECK_0~1166
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=21ddf6193de294fedaed670ac2678375e416cd37;p=openldap

controls can always have criticality set to FALSE (ITS#5785)
---

diff --git a/servers/slapd/controls.c b/servers/slapd/controls.c
index 496524f10a..ee2a36742f 100644
--- a/servers/slapd/controls.c
+++ b/servers/slapd/controls.c
@@ -960,12 +960,10 @@ static int parseDontUseCopy (
 		return LDAP_PROTOCOL_ERROR;
 	}
 
-	if ( !ctrl->ldctl_iscritical ) {
-		rs->sr_text = "dontUseCopy criticality of FALSE not allowed";
-		return LDAP_PROTOCOL_ERROR;
-	}
+	op->o_dontUseCopy = ctrl->ldctl_iscritical
+		? SLAP_CONTROL_CRITICAL
+		: SLAP_CONTROL_NONCRITICAL;
 
-	op->o_dontUseCopy = SLAP_CONTROL_CRITICAL;
 	return LDAP_SUCCESS;
 }