From: Pierangelo Masarati <ando@openldap.org>
Date: Thu, 22 Dec 2005 13:00:11 +0000 (+0000)
Subject: clarify regression testing
X-Git-Tag: OPENLDAP_REL_ENG_2_4_BP~520
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=23be60e73a2f1c69b71d89ebcdf6dc1af7ae8557;p=openldap

clarify regression testing
---

diff --git a/tests/README b/tests/README
index 5f4e307d6a..1a3feed162 100644
--- a/tests/README
+++ b/tests/README
@@ -8,6 +8,7 @@ verify basic functionality of the LDAP libraries, slapd, and slurpd.
 	To run SQL tests, define SLAPD_USE_SQL=<rdbms> and type
 		"make sql"; define SLAPD_USE_SQLWRITE=yes
 		to enable write tests as well.
+	To run regression tests, type "make regressions"
 
 The test scripts depends on a number of tools commonly available on
 Unix (and Unix-like) systems.  While attempts have been made to make
diff --git a/tests/data/regressions/README b/tests/data/regressions/README
index 9082e03e28..76fb87e54c 100644
--- a/tests/data/regressions/README
+++ b/tests/data/regressions/README
@@ -12,3 +12,7 @@ otherwise, if the issue appears whatever backend is used, the test should
 be parametric, so that it is run with the backend selected at run-time
 via the "-b" switch of the "run" script.
 
+Regression tests are prepared on a voluntary basis, so don't expect all 
+bugs to have a test any soon.  When the issue reporter provides a simple,
+yet complete means to reproduce the bug she's reporting, this may speed up 
+the process.  In case, only put neutral data in bug exploitation reports.
diff --git a/tests/data/regressions/its4184/its4184 b/tests/data/regressions/its4184/its4184
index b04cf45f54..ef87f45163 100755
--- a/tests/data/regressions/its4184/its4184
+++ b/tests/data/regressions/its4184/its4184
@@ -64,6 +64,13 @@ if test $RC != 0 ; then
 	exit $RC
 fi
 
+echo ""
+echo "	This test applies a round of updates __after__ grabbing a lock"
+echo "	that, before the fix, was not correctly released; in case "
+echo "	of failure, the second round of updates will deadlock."
+echo "	This issue was fixed in OpenLDAP 2.3.14."
+echo ""
+
 for S in 1 2 ; do
 	FILE="${ITSDIR}/mods.ldif"
 	echo "${S}) Applying `basename ${FILE}`..."