From: Hallvard Furuseth <hallvard@openldap.org>
Date: Tue, 8 Jan 2008 16:23:05 +0000 (+0000)
Subject: ldap_pvt_thread_pool_getkey() arg 'data' should point to a void* variable
X-Git-Tag: OPENLDAP_REL_ENG_2_4_9~20^2~240
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=2ab2740cbbf25d3f8ae1b93a7de2beeafa6ce6c6;p=openldap

ldap_pvt_thread_pool_getkey() arg 'data' should point to a void* variable
---

diff --git a/contrib/slapd-modules/smbk5pwd/smbk5pwd.c b/contrib/slapd-modules/smbk5pwd/smbk5pwd.c
index 85a6260d57..545a00cc72 100644
--- a/contrib/slapd-modules/smbk5pwd/smbk5pwd.c
+++ b/contrib/slapd-modules/smbk5pwd/smbk5pwd.c
@@ -268,7 +268,7 @@ static int k5key_chk(
 	const struct berval *cred,
 	const char **text )
 {
-	void *ctx;
+	void *ctx, *op_tmp;
 	Operation *op;
 	int rc;
 	Entry *e;
@@ -281,9 +281,10 @@ static int k5key_chk(
 	/* Find our thread context, find our Operation */
 	ctx = ldap_pvt_thread_pool_context();
 
-	if ( ldap_pvt_thread_pool_getkey( ctx, smbk5pwd_op_cleanup, (void **)&op, NULL ) ||
-		!op )
+	if ( ldap_pvt_thread_pool_getkey( ctx, smbk5pwd_op_cleanup, &op_tmp, NULL )
+		 || !op_tmp )
 		return LUTIL_PASSWD_ERR;
+	op = op_tmp;
 
 	rc = be_entry_get_rw( op, &op->o_req_ndn, NULL, NULL, 0, &e );
 	if ( rc != LDAP_SUCCESS ) return LUTIL_PASSWD_ERR;