From: Howard Chu <hyc@openldap.org>
Date: Fri, 10 Nov 2006 07:47:51 +0000 (+0000)
Subject: ITS#4741 from HEAD
X-Git-Tag: OPENLDAP_REL_ENG_2_3_29~1
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=2db1ab7028074733ddb54313d951c95989092984;p=openldap

ITS#4741 from HEAD
---

diff --git a/servers/slapd/overlays/ppolicy.c b/servers/slapd/overlays/ppolicy.c
index 645dd6f3d5..14febffafd 100644
--- a/servers/slapd/overlays/ppolicy.c
+++ b/servers/slapd/overlays/ppolicy.c
@@ -553,13 +553,12 @@ check_password_quality( struct berval *cred, PassPolicy *pp, LDAPPasswordPolicyE
 				ldap_pvt_thread_mutex_lock( &chk_syntax_mutex );
 				ok = prog( cred->bv_val, &txt, e );
 				ldap_pvt_thread_mutex_unlock( &chk_syntax_mutex );
-				if (txt) {
+				if (ok != LDAP_SUCCESS) {
 					Debug(LDAP_DEBUG_ANY,
 						"check_password_quality: module error: (%s) %s.[%d]\n",
-						pp->pwdCheckModule, txt, ok );
+						pp->pwdCheckModule, txt ? txt : "", ok );
 					free(txt);
-				} else
-					ok = LDAP_SUCCESS;
+				}
 			}
 			    
 			lt_dlclose( mod );