From: Pierangelo Masarati <ando@openldap.org>
Date: Tue, 18 Nov 2008 16:27:50 +0000 (+0000)
Subject: check for bogus params to an LDAP routine (ITS#5817)
X-Git-Tag: ACLCHECK_0~1078
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=2eeefd4985d0a239b299ae74046b23b49cd02c4a;p=openldap

check for bogus params to an LDAP routine (ITS#5817)
---

diff --git a/libraries/libldap/add.c b/libraries/libldap/add.c
index d993650613..1a50a7929f 100644
--- a/libraries/libldap/add.c
+++ b/libraries/libldap/add.c
@@ -151,9 +151,32 @@ ldap_add_ext(
 		/* for each attribute in the entry... */
 		for ( i = 0; attrs[i] != NULL; i++ ) {
 			if ( ( attrs[i]->mod_op & LDAP_MOD_BVALUES) != 0 ) {
+				int j;
+
+				if ( attrs[i]->mod_bvalues == NULL ) {
+					ld->ld_errno = LDAP_PARAM_ERROR;
+					ber_free( ber, 1 );
+					return ld->ld_errno;
+				}
+
+				for ( j = 0; attrs[i]->mod_bvalues[ j ] != NULL; j++ ) {
+					if ( attrs[i]->mod_bvalues[ j ]->bv_val == NULL ) {
+						ld->ld_errno = LDAP_PARAM_ERROR;
+						ber_free( ber, 1 );
+						return ld->ld_errno;
+					}
+				}
+
 				rc = ber_printf( ber, "{s[V]N}", attrs[i]->mod_type,
 				    attrs[i]->mod_bvalues );
+
 			} else {
+				if ( attrs[i]->mod_values == NULL ) {
+					ld->ld_errno = LDAP_PARAM_ERROR;
+					ber_free( ber, 1 );
+					return ld->ld_errno;
+				}
+
 				rc = ber_printf( ber, "{s[v]N}", attrs[i]->mod_type,
 				    attrs[i]->mod_values );
 			}