From: Michael Stapelberg <michael@stapelberg.de>
Date: Sun, 18 Sep 2011 16:43:02 +0000 (+0100)
Subject: Bugfix: Only change focus in tree_close() when the container was focused before
X-Git-Tag: 4.1~148^2^2
X-Git-Url: https://git.sur5r.net/?a=commitdiff_plain;h=2fe0949abd8b73a5dbc3c7f825982f79ecfa976d;p=i3%2Fi3

Bugfix: Only change focus in tree_close() when the container was focused before

Fixes: #441

I’m not sure if that’s really all there is to it. Seems a bit too simple :).
We’ll see if I missed some corner cases in the next few days…
---

diff --git a/src/tree.c b/src/tree.c
index 240c22a6..0d0c2e9f 100644
--- a/src/tree.c
+++ b/src/tree.c
@@ -220,12 +220,13 @@ bool tree_close(Con *con, kill_window_t kill_window, bool dont_kill_parent) {
     if (was_mapped || con == focused) {
         if ((kill_window != DONT_KILL_WINDOW) || !dont_kill_parent || con == focused) {
             DLOG("focusing %p / %s\n", next, next->name);
-            /* TODO: check if the container (or one of its children) was focused */
             if (next->type == CT_DOCKAREA) {
                 /* Instead of focusing the dockarea, we need to restore focus to the workspace */
                 con_focus(con_descend_focused(output_get_content(next->parent)));
             } else {
-                con_focus(next);
+                if (con != focused)
+                    DLOG("not changing focus, the container was not focused before\n");
+                else con_focus(next);
             }
         }
         else {